----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1146/ -----------------------------------------------------------
Review request for hive. Summary ------- In Task class and its subclasses logger is initialized in constructor. Log object no need to initialize every time in the constructor, Log object can make it as static object. This addresses bug HIVE-2183. https://issues.apache.org/jira/browse/HIVE-2183 Diffs ----- trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1145025 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/CopyTask.java 1145025 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java 1145025 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java 1145025 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 1145025 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java 1145025 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/MapredLocalTask.java 1145025 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 1145025 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java 1145025 trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java 1145025 trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java 1145025 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1145025 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/FunctionSemanticAnalyzer.java 1145025 Diff: https://reviews.apache.org/r/1146/diff Testing ------- All unit tests passed Thanks, chinna