[
https://issues.apache.org/jira/browse/HIVE-872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049354#comment-13049354
]
jirapos...@reviews.apache.org commented on HIVE-872:
----------------------------------------------------
bq. On 2011-06-14 19:14:04, John Sichi wrote:
bq. > Wouldn't it be better to change COALESCE to just check that the two
objects have the same type family (both numeric)? That's what happens in
standard SQL, and then the widest type is used for the result. This is what
UNION ALL should be doing also, although currently it uses the same annoying
check as COALESCE.
bq. >
Also, CAST(0 AS BIGINT) already works the same as 0L.
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/889/#review834
-----------------------------------------------------------
On 2011-06-14 19:04:53, Syed Albiz wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/889/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-06-14 19:04:53)
bq.
bq.
bq. Review request for hive and John Sichi.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Added a rule to the lexical grammar to allow BIGINT constants ending with
'L', and a clause to the TypeCheckProcFactory to ensure it gets interpreted
properly.
bq.
bq.
bq. This addresses bug HIVE-872.
bq. https://issues.apache.org/jira/browse/HIVE-872
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 9161319
bq. ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java
dfadb9f
bq. ql/src/test/queries/clientpositive/bigint_const.q PRE-CREATION
bq. ql/src/test/results/clientpositive/bigint_const.q.out PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/889/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. TestCliDriver passes, previous behaviour was to accept bigint constants
specified without 'L', which is also preserved, so adding additional tests for
this case seems unnecessary.
bq.
bq.
bq. Thanks,
bq.
bq. Syed
bq.
bq.
> Allow BIGINT constants
> ----------------------
>
> Key: HIVE-872
> URL: https://issues.apache.org/jira/browse/HIVE-872
> Project: Hive
> Issue Type: New Feature
> Reporter: Zheng Shao
> Assignee: Syed S. Albiz
> Attachments: HIVE-872.1.patch
>
>
> We should allow "0L" to be interpreted as a bigint constant.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
