[
https://issues.apache.org/jira/browse/HIVE-872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048881#comment-13048881
]
jirapos...@reviews.apache.org commented on HIVE-872:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/889/
-----------------------------------------------------------
(Updated 2011-06-13 23:32:55.134796)
Review request for hive and John Sichi.
Changes
-------
Added assert
Summary
-------
Added a rule to the lexical grammar to allow BIGINT constants ending with 'L',
and a clause to the TypeCheckProcFactory to ensure it gets interpreted properly.
This addresses bug HIVE-872.
https://issues.apache.org/jira/browse/HIVE-872
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 9161319
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java dfadb9f
ql/src/test/queries/clientpositive/bigint_const.q PRE-CREATION
ql/src/test/results/clientpositive/bigint_const.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/889/diff
Testing
-------
TestCliDriver passes, previous behaviour was to accept bigint constants
specified without 'L', which is also preserved, so adding additional tests for
this case seems unnecessary.
Thanks,
Syed
> Allow BIGINT constants
> ----------------------
>
> Key: HIVE-872
> URL: https://issues.apache.org/jira/browse/HIVE-872
> Project: Hive
> Issue Type: New Feature
> Reporter: Zheng Shao
> Assignee: Syed S. Albiz
> Attachments: HIVE-872.1.patch
>
>
> We should allow "0L" to be interpreted as a bigint constant.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
