[ https://issues.apache.org/jira/browse/HIVE-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045759#comment-13045759 ]
jirapos...@reviews.apache.org commented on HIVE-2188: ----------------------------------------------------- bq. On 2011-06-07 20:09:34, Carl Steinbach wrote: bq. > trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java, line 748 bq. > <https://reviews.apache.org/r/831/diff/3/?file=20654#file20654line748> bq. > bq. > Sorry I missed this before, but you need to add a getTableObjectsByName() method to IMetaStoreClient and HiveMetaStoreClient, and use that method here instead of calling client.client.get_table_objects_by_name(). Everything else looks good so, so you can either update this patch, or else open another ticket to address this issue. Please let me know what you want to do. Thanks. Hi Carl, I have updated the patch here. Thanks for your help. - Sohan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/831/#review778 ----------------------------------------------------------- On 2011-06-07 01:11:44, Sohan Jain wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/831/ bq. ----------------------------------------------------------- bq. bq. (Updated 2011-06-07 01:11:44) bq. bq. bq. Review request for hive, Paul Yang and Ashutosh Chauhan. bq. bq. bq. Summary bq. ------- bq. bq. Created a function "multi_get_table" that retrieves multiple tables on one trip to the hive metastore, saving round trip time. bq. bq. bq. This addresses bug HIVE-2188. bq. https://issues.apache.org/jira/browse/HIVE-2188 bq. bq. bq. Diffs bq. ----- bq. bq. trunk/metastore/if/hive_metastore.thrift 1130342 bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1130342 bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1130342 bq. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 1130342 bq. trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 1130342 bq. bq. Diff: https://reviews.apache.org/r/831/diff bq. bq. bq. Testing bq. ------- bq. bq. Added a test case to testMetasore() in TestHiveServer. Also tested for speed improvements in a client session. bq. bq. bq. Thanks, bq. bq. Sohan bq. bq. > Add multi_get_table function in Hive Metastore > ---------------------------------------------- > > Key: HIVE-2188 > URL: https://issues.apache.org/jira/browse/HIVE-2188 > Project: Hive > Issue Type: New Feature > Components: Metastore > Reporter: Sohan Jain > Assignee: Sohan Jain > Priority: Minor > Attachments: HIVE-2188.1.patch, HIVE-2188.3.patch > > > This function would get multiple tables from the hive metastore as opposed to > just one at a time, saving round trip time to the metastore. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira