[ 
https://issues.apache.org/jira/browse/HIVE-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042031#comment-13042031
 ] 

jirapos...@reviews.apache.org commented on HIVE-2154:
-----------------------------------------------------



bq.  On 2011-06-01 06:48:14, Ning Zhang wrote:
bq.  > 
trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerUtil.java,
 line 57
bq.  > <https://reviews.apache.org/r/812/diff/2/?file=20084#file20084line57>
bq.  >
bq.  >     Do you need to throw exception when all handler return false?

ioExpectionHandlerChain will throw exception if all handler returns false.


- Yongqiang


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/812/#review741
-----------------------------------------------------------


On 2011-06-01 00:38:42, Yongqiang He wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/812/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-06-01 00:38:42)
bq.  
bq.  
bq.  Review request for hive.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  add exception handling to hive's record reader
bq.  
bq.  
bq.  This addresses bug HIVE-2154.
bq.      https://issues.apache.org/jira/browse/HIVE-2154
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/conf/hive-default.xml 1129953 
bq.    
trunk/ql/src/java/org/apache/hadoop/hive/ql/io/BucketizedHiveRecordReader.java 
1129953 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 
1129953 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveRecordReader.java 
1129953 
bq.    
trunk/ql/src/java/org/apache/hadoop/hive/ql/io/SymlinkTextInputFormat.java 
1129953 
bq.    
trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketMapJoinOptimizer.java
 1129953 
bq.    
trunk/shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java 
1129953 
bq.    
trunk/shims/src/0.20S/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java 
1129953 
bq.    
trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandler.java
 PRE-CREATION 
bq.    
trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerChain.java
 PRE-CREATION 
bq.    
trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerUtil.java
 PRE-CREATION 
bq.    
trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionNextHandleResult.java
 PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/812/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Yongqiang
bq.  
bq.



> add exception handling to hive's record reader 
> -----------------------------------------------
>
>                 Key: HIVE-2154
>                 URL: https://issues.apache.org/jira/browse/HIVE-2154
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: He Yongqiang
>            Assignee: He Yongqiang
>         Attachments: HIVE-2154.1.patch, HIVE-2154.2.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to