[
https://issues.apache.org/jira/browse/HIVE-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041835#comment-13041835
]
jirapos...@reviews.apache.org commented on HIVE-2154:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/812/#review740
-----------------------------------------------------------
trunk/conf/hive-default.xml
<https://reviews.apache.org/r/812/#comment1493>
comment should be more specific: class names of the exception handlers.
trunk/ql/src/java/org/apache/hadoop/hive/ql/io/BucketizedHiveRecordReader.java
<https://reviews.apache.org/r/812/#comment1494>
rename the variable to indicate it is a chain rather than just 1 handler.
trunk/ql/src/java/org/apache/hadoop/hive/ql/io/BucketizedHiveRecordReader.java
<https://reviews.apache.org/r/812/#comment1497>
this function throws IOException but the original code throws
RuntimeException. Should check if this is OK.
trunk/ql/src/java/org/apache/hadoop/hive/ql/io/BucketizedHiveRecordReader.java
<https://reviews.apache.org/r/812/#comment1496>
same as below
trunk/ql/src/java/org/apache/hadoop/hive/ql/io/BucketizedHiveRecordReader.java
<https://reviews.apache.org/r/812/#comment1495>
check if the function return false and throw exception
trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java
<https://reviews.apache.org/r/812/#comment1498>
indentation
trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java
<https://reviews.apache.org/r/812/#comment1499>
comment on what the innerReader is when there is an exception in the first
call of getRecordReader().
trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java
<https://reviews.apache.org/r/812/#comment1500>
also need to throw exception when all handlers return false. Should try to
refactor the code
- Ning
On 2011-05-31 20:31:23, Yongqiang He wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/812/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-05-31 20:31:23)
bq.
bq.
bq. Review request for hive.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. add exception handling to hive's record reader
bq.
bq.
bq. This addresses bug HIVE-2154.
bq. https://issues.apache.org/jira/browse/HIVE-2154
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/conf/hive-default.xml 1127229
bq.
trunk/ql/src/java/org/apache/hadoop/hive/ql/io/BucketizedHiveRecordReader.java
1101261
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java
1101261
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveRecordReader.java
1101261
bq.
trunk/ql/src/java/org/apache/hadoop/hive/ql/io/SymlinkTextInputFormat.java
1101261
bq.
trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketMapJoinOptimizer.java
1101261
bq.
trunk/shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java
1101261
bq.
trunk/shims/src/0.20S/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java
1101261
bq.
trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandler.java
PRE-CREATION
bq.
trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerChain.java
PRE-CREATION
bq.
trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionNextHandleResult.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/812/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Yongqiang
bq.
bq.
> add exception handling to hive's record reader
> -----------------------------------------------
>
> Key: HIVE-2154
> URL: https://issues.apache.org/jira/browse/HIVE-2154
> Project: Hive
> Issue Type: Improvement
> Reporter: He Yongqiang
> Assignee: He Yongqiang
> Attachments: HIVE-2154.1.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
