----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/491/#review330 -----------------------------------------------------------
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java <https://reviews.apache.org/r/491/#comment671> The two approaches, using anonymous class, or a complete wrapper, both have pros and cons. The cons of this embedded approach is that it makes it harder to read since the scopes of variables are not very clear to read. On the other hand, the codes are more straight-forward to write and read since the control flow is linear. However, the wrapper class also has its cons. By randomly combine variables needed by a worker thread into a class, we sometimes break the nice abstraction of OO. The codes can be very confusing too. For this case, combining Path, JobConf, conf, PartitionDesc and resultMap doesn't generate a object that makes sense. In my opinion, using a embedded approach might be a better choice. - Siying On 2011-03-11 15:03:34, Carl Steinbach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/491/ > ----------------------------------------------------------- > > (Updated 2011-03-11 15:03:34) > > > Review request for hive. > > > Summary > ------- > > Review request for HIVE-2051. > > > This addresses bug HIVE-2051. > https://issues.apache.org/jira/browse/HIVE-2051 > > > Diffs > ----- > > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1080771 > > Diff: https://reviews.apache.org/r/491/diff > > > Testing > ------- > > > Thanks, > > Carl > >
