----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/491/#review326 -----------------------------------------------------------
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java <https://reviews.apache.org/r/491/#comment660> I'll make the change. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java <https://reviews.apache.org/r/491/#comment661> What's the benefit of it? trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java <https://reviews.apache.org/r/491/#comment662> Only when we make it final, different threads can access this value exclusively. I'm not sure the best way to do that. Do you have better suggestion? trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java <https://reviews.apache.org/r/491/#comment665> Do we need it if we do executor.shutdown()? trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java <https://reviews.apache.org/r/491/#comment663> Here is the desciption of shutdown(): "void shutdown()Initiates an orderly shutdown in which previously submitted tasks are executed, but no new tasks will be accepted. Invocation has no additional effect if already shut down." "An ExecutorService can be shut down, which will cause it to reject new tasks. Two different methods are provided for shutting down an ExecutorService. The shutdown() method will allow previously submitted tasks to execute before terminating, while the shutdownNow() method prevents waiting tasks from starting and attempts to stop currently executing tasks." All submitted jobs should guarantee to finish. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java <https://reviews.apache.org/r/491/#comment664> will make the change. - Siying On 2011-03-11 15:03:34, Carl Steinbach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/491/ > ----------------------------------------------------------- > > (Updated 2011-03-11 15:03:34) > > > Review request for hive. > > > Summary > ------- > > Review request for HIVE-2051. > > > This addresses bug HIVE-2051. > https://issues.apache.org/jira/browse/HIVE-2051 > > > Diffs > ----- > > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1080771 > > Diff: https://reviews.apache.org/r/491/diff > > > Testing > ------- > > > Thanks, > > Carl > >
