----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/352/#review203 -----------------------------------------------------------
Ship it! +1 - Paul On 2011-02-07 14:14:06, Sushanth Sowmyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/352/ > ----------------------------------------------------------- > > (Updated 2011-02-07 14:14:06) > > > Review request for hive. > > > Summary > ------- > > HIVE-1818 : jmx instrumentation for HiveMetaStore call frequency and duration > > > This addresses bug HIVE-1818. > https://issues.apache.org/jira/browse/HIVE-1818 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/Metrics.java > PRE-CREATION > > http://svn.apache.org/repos/asf/hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBean.java > PRE-CREATION > > http://svn.apache.org/repos/asf/hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBeanImpl.java > PRE-CREATION > > http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 1068155 > > http://svn.apache.org/repos/asf/hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java > 1068155 > > Diff: https://reviews.apache.org/r/352/diff > > > Testing > ------- > > > Thanks, > > Sushanth > >