----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/352/#review182 -----------------------------------------------------------
1 more comment, but looks great overall. Once this is addressed, I'll test & commit http://svn.apache.org/repos/asf/hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/Metrics.java <https://reviews.apache.org/r/352/#comment350> Instead of calling reopen(), can you call open as you did before? The reason for this is that later on, there might be a programming error where a method calls startScope twice in a row. Because reopen() is called, the error will be masked. If we change it to open(), then an exception will be thrown and we will know that we have mis-matched start/endScope calls. - Paul On 2011-02-02 10:23:23, Sushanth Sowmyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/352/ > ----------------------------------------------------------- > > (Updated 2011-02-02 10:23:23) > > > Review request for hive. > > > Summary > ------- > > HIVE-1818 : jmx instrumentation for HiveMetaStore call frequency and duration > > > This addresses bug HIVE-1818. > https://issues.apache.org/jira/browse/HIVE-1818 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/Metrics.java > PRE-CREATION > > http://svn.apache.org/repos/asf/hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBean.java > PRE-CREATION > > http://svn.apache.org/repos/asf/hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBeanImpl.java > PRE-CREATION > > http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 1066213 > > http://svn.apache.org/repos/asf/hive/trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java > 1066213 > > Diff: https://reviews.apache.org/r/352/diff > > > Testing > ------- > > > Thanks, > > Sushanth > >
