ok2c commented on code in PR #715:
URL:
https://github.com/apache/httpcomponents-core/pull/715#discussion_r4183928875
##########
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/nio/pool/H2ConnPool.java:
##########
@@ -65,16 +67,27 @@ public final class H2ConnPool extends
AbstractIOSessionPool<HttpHost> {
private volatile TimeValue validateAfterInactivity =
TimeValue.NEG_ONE_MILLISECOND;
+ /**
+ * @since 5.5
+ */
public H2ConnPool(
+ final Clock clock,
final ConnectionInitiator connectionInitiator,
final Resolver<HttpHost, InetSocketAddress> addressResolver,
final TlsStrategy tlsStrategy) {
- super();
+ super(clock);
this.connectionInitiator = Args.notNull(connectionInitiator,
"Connection initiator");
- this.addressResolver = addressResolver != null ? addressResolver :
DefaultAddressResolver.INSTANCE;
+ this.addressResolver = addressResolver;
Review Comment:
@arturobernalg It was. H2ConnPool violates our package layering policy by
importing an impl class into a non-impl one. However you likely have more
violations like that. They all should be addressed consistency across teh
entire code base.
I reverted my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
