arturobernalg commented on code in PR #715:
URL:
https://github.com/apache/httpcomponents-core/pull/715#discussion_r4183488500
##########
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/nio/pool/H2ConnPool.java:
##########
@@ -65,16 +67,27 @@ public final class H2ConnPool extends
AbstractIOSessionPool<HttpHost> {
private volatile TimeValue validateAfterInactivity =
TimeValue.NEG_ONE_MILLISECOND;
+ /**
+ * @since 5.5
+ */
public H2ConnPool(
+ final Clock clock,
final ConnectionInitiator connectionInitiator,
final Resolver<HttpHost, InetSocketAddress> addressResolver,
final TlsStrategy tlsStrategy) {
- super();
+ super(clock);
this.connectionInitiator = Args.notNull(connectionInitiator,
"Connection initiator");
- this.addressResolver = addressResolver != null ? addressResolver :
DefaultAddressResolver.INSTANCE;
+ this.addressResolver = addressResolver;
Review Comment:
Was the change in the `addressResolver` fallback intentional? With a null
resolver this no longer seems equivalent to `DefaultAddressResolver`, in
particular for default ports and an explicitly provided `HttpHost` address.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
