arturobernalg commented on PR #592: URL: https://github.com/apache/httpcomponents-core/pull/592#issuecomment-3705157200
> @arturobernalg Conceptually everything looks good to me. However as far as I can see you are also mixing in some code optimization into the same change-set. > > Could you please do this? > > 1. Spin the optimization code into a separate pull request. It should get merged in first. > > 2. Re-base this pull request off it > > 3. Provide the same logic to `HttpAsyncRequester` for consistency. @ok2c Please another pass -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
