arturobernalg commented on code in PR #592:
URL:
https://github.com/apache/httpcomponents-core/pull/592#discussion_r2656356657
##########
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/bootstrap/H2MultiplexingRequester.java:
##########
@@ -182,83 +209,54 @@ private void execute(
if (request.getAuthority() == null) {
request.setAuthority(new URIAuthority(host));
}
+ if (request.getScheme() == null) {
+ request.setScheme(host.getSchemeName());
+ }
connPool.getSession(host, timeout, new
FutureCallback<IOSession>() {
@Override
public void completed(final IOSession ioSession) {
- final AsyncClientExchangeHandler handlerProxy = new
AsyncClientExchangeHandler() {
- @Override
- public void releaseResources() {
+ final int max = maxRequestsPerConnection;
Review Comment:
> @arturobernalg Why, why all this complexity? You are not going to impress
no young ladies with it. You almost had it right last time. Restore the command
count method from the previous revision and fail the request if the total
number of pending commands is over the max limit. That should be all. The
tricky bit is to come up with a reasonable config mechanism for the max pending
command limit.
Hi @ok2c , I’ve ditched the extra plumbing and went back to the simple
approach: restored the command-count method and now H2MultiplexingRequester
just fails fast when pending commands exceed the configured max.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
