ok2c commented on PR #771: URL: https://github.com/apache/httpcomponents-client/pull/771#issuecomment-3665489040
> I’m not convinced OFFLOCK needs ConnPoolListener at all. > RouteSegmentedConnPool is intentionally lean / low-level: adding listener callbacks means extra branches and memory traffic on the hot lease/release paths, which is exactly what OFFLOCK is trying to minimize. @arturobernalg This may well be the case, null listener should have no performance impact, should it? And if the user explicitly chooses `OFFLOCK ` policy _and_ a custom listener, why should we deny that? Just because the pool may have sub-optimal performance? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
