arturobernalg commented on PR #771: URL: https://github.com/apache/httpcomponents-client/pull/771#issuecomment-3665359660
> > Hello @ok2c, > > Thank you for the quick feedback. > > Please note one of the new pool implementation in core5 (`RouteSegmentedConnPool`) do not ship this `ConnPoolListener` interface. > > I was wondering if I should also update the core so that pool event subscription is consistent between all implementations ? > > @neoXfire Yes, please do so. Could you please also add a TODO comment to `OFFLOCK` policy about missing `ConnPoolListener` support in both connection managers? I’m not convinced OFFLOCK needs ConnPoolListener at all. RouteSegmentedConnPool is intentionally lean / low-level: adding listener callbacks means extra branches and memory traffic on the hot lease/release paths, which is exactly what OFFLOCK is trying to minimize. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
