ok2c commented on code in PR #543:
URL:
https://github.com/apache/httpcomponents-core/pull/543#discussion_r2267013823
##########
httpcore5/src/main/java/org/apache/hc/core5/http/impl/nio/AbstractHttp1StreamDuplexer.java:
##########
@@ -277,13 +278,14 @@ public final void onInput(final ByteBuffer src) throws
HttpException, IOExceptio
return;
}
- boolean endOfStream = false;
if (incomingMessage == null) {
final int bytesRead = inbuf.fill(ioSession);
Review Comment:
> I was hoping we could figure out how to do the same thing in the case of
TLS.
@rschmitt I do not think this can be done. Not without a major rewrite of
the TLS layer. Presently the TLS layer and the HTTP protocol layers are
decoupled and the protocol layer can interact with the lower transport layer
through a generic `IOSession` interface. I do not see a way of making it
reliably run through the TLS close notify handshake from the protocol handler.
I really think we ought to focus on #547 or something similar (such as using
OPTIONS as a poor man's version of H2 ping)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
