rschmitt commented on code in PR #543:
URL: 
https://github.com/apache/httpcomponents-core/pull/543#discussion_r2265395330


##########
httpcore5/src/main/java/org/apache/hc/core5/http/impl/nio/AbstractHttp1StreamDuplexer.java:
##########
@@ -277,13 +278,14 @@ public final void onInput(final ByteBuffer src) throws 
HttpException, IOExceptio
             return;
         }
 
-        boolean endOfStream = false;
         if (incomingMessage == null) {
             final int bytesRead = inbuf.fill(ioSession);

Review Comment:
   Your changes in this PR significantly improved things by causing 
`RequestNotExecutedException` (a safely retryable exception) to be thrown much 
more consistently in this case. I was hoping we could figure out how to do the 
same thing in the case of TLS.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

Reply via email to