001mertiya commented on code in PR #296: URL: https://github.com/apache/httpcomponents-client/pull/296#discussion_r2195025196
########## httpclient5/src/main/java/org/apache/hc/client5/http/config/ConnectionConfig.java: ########## @@ -0,0 +1,205 @@ +/* + * ==================================================================== + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + * ==================================================================== + * + * This software consists of voluntary contributions made by many + * individuals on behalf of the Apache Software Foundation. For more + * information on the Apache Software Foundation, please see + * <http://www.apache.org/>. + * + */ + +package org.apache.hc.client5.http.config; + +import java.util.concurrent.TimeUnit; + +import org.apache.hc.core5.annotation.Contract; +import org.apache.hc.core5.annotation.ThreadingBehavior; +import org.apache.hc.core5.util.TimeValue; +import org.apache.hc.core5.util.Timeout; + +/** + * Immutable class encapsulating connection initialization and management settings. + * + * @since 5.2 + */ +@Contract(threading = ThreadingBehavior.IMMUTABLE) +public class ConnectionConfig implements Cloneable { + + private static final Timeout DEFAULT_CONNECT_TIMEOUT = Timeout.ofMinutes(3); + + public static final ConnectionConfig DEFAULT = new Builder().build(); + + private final Timeout connectTimeout; + private final Timeout socketTimeout; + private final TimeValue validateAfterInactivity; Review Comment: Correct, but `connectionRequestTimeout` is the timeout used when requesting a connection from the connection pool. I think it should be part of `ConnectionConfig` or there should be a way to set it in `PoolingAsyncClientConnectionManager`, as it is a property of the connection pool. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
