michael-o commented on code in PR #614:
URL:
https://github.com/apache/httpcomponents-client/pull/614#discussion_r1925804726
##########
httpclient5/src/main/java/org/apache/hc/client5/http/auth/AuthExchange.java:
##########
@@ -38,6 +38,9 @@
*/
public class AuthExchange {
+ // This only tracks the server state. In particular, even if the state is
SUCCESS,
+ // the authentication may still fail if the challenge sent with an
authorized response cannot
+ // be validated locally for AuthScheme2 schemes.
Review Comment:
`AuthScheme2` is gone
##########
httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/ProtocolExec.java:
##########
@@ -218,6 +221,8 @@ public ClassicHttpResponse execute(
EntityUtils.consume(responseEntity);
} else {
execRuntime.disconnectEndpoint();
+ // We don't have any connection based AuthScheme2
implementations.
Review Comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
