stoty commented on PR #614: URL: https://github.com/apache/httpcomponents-client/pull/614#issuecomment-2607593116
Thank you @ok2c . Using a default method instead of a new interface is a definite improvement over my version. Two small issues: 1. This is only half of the solution for HTTPCLIENT-1625, I think it would be better to use HTTPCLIENT-2356 in the commit message. (I have not updated the commit message on my original PR to preserve continuity while reviewing, but was planning to) 2. This has my original mix of "authorization"/"authentication" log messages, you may want do a pass on those. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org