arturobernalg commented on code in PR #609:
URL:
https://github.com/apache/httpcomponents-client/pull/609#discussion_r1907910836
##########
httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/ResponseCachingPolicy.java:
##########
@@ -248,6 +256,9 @@ protected boolean isExplicitlyCacheable(final
ResponseCacheControl cacheControl,
if (response.containsHeader(HttpHeaders.EXPIRES)) {
return true;
}
+ if (cacheControl.getMaxAge() == 0 && cacheControl.isMustRevalidate()) {
Review Comment:
@ok2c Looks reasonable to me as it directly addresses the core condition
around Authorization and shared caches
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
