ok2c commented on code in PR #609:
URL:
https://github.com/apache/httpcomponents-client/pull/609#discussion_r1907887614
##########
httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/ResponseCachingPolicy.java:
##########
@@ -248,6 +256,9 @@ protected boolean isExplicitlyCacheable(final
ResponseCacheControl cacheControl,
if (response.containsHeader(HttpHeaders.EXPIRES)) {
return true;
}
+ if (cacheControl.getMaxAge() == 0 && cacheControl.isMustRevalidate()) {
Review Comment:
@arturobernalg Fine by me but I see no mentioning of `max-age=0` anywhere in
that section. The only change I would consider reasonable based on my
interpretation of the section is this:
https://github.com/ok2c/httpcomponents-client/commit/f4a187063112e87620827d21e9b140d54f7011a3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
