ok2c commented on code in PR #598:
URL:
https://github.com/apache/httpcomponents-client/pull/598#discussion_r1844955555
##########
httpclient5/src/main/java/org/apache/hc/client5/http/DnsResolver.java:
##########
@@ -61,4 +67,21 @@ public interface DnsResolver {
*/
String resolveCanonicalHostname(String host) throws UnknownHostException;
+ /**
+ * Returns a list of {@link SocketAddress} for the given host with the
given port.
+ *
+ * @see SocketAddress
+ *
+ * @since 5.5
+ */
+ default List<SocketAddress> resolve(String host, int port) throws
UnknownHostException {
Review Comment:
@arturobernalg Almost there. Let's change this method to return
`List<InetSocketAddress>` in order to avoid ugly downcasts in several places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
