ok2c commented on code in PR #598:
URL:
https://github.com/apache/httpcomponents-client/pull/598#discussion_r1844152388
##########
httpclient5/src/test/java/org/apache/hc/client5/http/impl/io/TestPoolingHttpClientConnectionManager.java:
##########
@@ -307,10 +308,10 @@ void testProxyConnectAndUpgrade() throws Exception {
Mockito.when(conn.isOpen()).thenReturn(false);
Mockito.when(future.get(1, TimeUnit.SECONDS)).thenReturn(entry);
Mockito.when(pool.lease(
- Mockito.eq(route),
- Mockito.eq(null),
- Mockito.any(),
- Mockito.eq(null)))
+ Mockito.eq(route),
Review Comment:
@arturobernalg Can we avoid formatting changes in the same commit with
functional ones? If you want to change formatting please do it through the
style check or at least in a separate commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
