ok2c commented on PR #590: URL: https://github.com/apache/httpcomponents-client/pull/590#issuecomment-2421672574
> @ok2c I have noticed in the `org.apache.hc.core5.reactor.InternalConnectChannel#onIOEvent` method of httpcore5, at lines 78 and 79, that the correct execution order might be: > > ```java > dataChannel.handleIOEvent(SelectionKey.OP_CONNECT); > sessionRequest.completed(dataChannel); > ``` > @yhzdys This is more of a conceptual question as to what must happens first, session request completion event or session connected event. Presently, the former happens first. If I reverse the sequence I see some test cases fail. This does not meant the failing test cases cannot be fixed but we need to decide what a conceptually correct course of events here is -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
