yhzdys commented on PR #590:
URL: 
https://github.com/apache/httpcomponents-client/pull/590#issuecomment-2421629814

   @ok2c 
   I have noticed in the 
`org.apache.hc.core5.reactor.InternalConnectChannel#onIOEvent` method of 
httpcore5, at lines 78 and 79, that the correct execution order might be:
   
   ```java
   dataChannel.handleIOEvent(SelectionKey.OP_CONNECT);
   sessionRequest.completed(dataChannel);
   ```
   
   This ensures that the state of the `IOEventHandler` is updated first before 
proceeding with the subsequent callback tasks. 
   A similar issue also appears in the 
`org.apache.hc.core5.reactor.SocksProxyProtocolHandler#inputReady` method.
   However, I am not certain if my understanding is correct.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

Reply via email to