garydgregory commented on code in PR #574:
URL:
https://github.com/apache/httpcomponents-client/pull/574#discussion_r1730047259
##########
httpclient5/pom.xml:
##########
@@ -105,6 +105,7 @@
<directory>src/main/resources</directory>
<filtering>true</filtering>
<includes>
+ <include>**/*.dat</include>
Review Comment:
Hello @ok2c
Well, we're both right. I've pushed a new version that cleanly separates the
concerns of which file to copy and whether to filter it or not by using two
`<resource>` elements:
- We want the `.properties` file copied _and_ filtered. The git master
version causes _only_ the properties file to be copied, the `.dat` file is not
copied.
- We want to the `.dat` file copied but _not_ filtered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
