ok2c commented on code in PR #574:
URL:
https://github.com/apache/httpcomponents-client/pull/574#discussion_r1730030296
##########
httpclient5/pom.xml:
##########
@@ -105,6 +105,7 @@
<directory>src/main/resources</directory>
<filtering>true</filtering>
<includes>
+ <include>**/*.dat</include>
Review Comment:
> Yes, because other resources are already filtered and we want to include
the new `.dat` file.
@garydgregory I may be mistaken, but resource filtering is used to replace
variable placeholders with system or project variables, not to filter (include
/ exclude) resources. [1]. We already have `mozilla/public-suffix-list.txt`
resource that gets added to the artifact jar, even though `*.txt` files are not
filters. Am I missing something?
We do not need to filter `.dat` files, do we?
[1]
https://maven.apache.org/plugins/maven-resources-plugin/examples/filter.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
