ok2c commented on PR #566: URL: https://github.com/apache/httpcomponents-client/pull/566#issuecomment-2293438025
@massdosage I am fine with your changes to the `PublicSuffixMatcher` class. However I do think we must preserve the original behavior of `#matchIdentity` method of `DefaultHostnameVerifier`. At the very least all tests involving `amazonaws.com` need to retain their original behavior as they are based on the real-life usage scenarios reported by HttpClient users. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
