On Sat, 2024-06-29 at 10:27 +0200, Oleg Kalnichevski wrote: > On Thu, 2024-06-27 at 19:17 +0000, Gary D. Gregory wrote: > > +1 > > > > Tested src zip > > - ASC OK > > - SHA512 OK; shasum --check now works! :) > > - On Windows, tested: mvn clean verify -P !use-toolchains > > > > BUT using git's bash install on Windows 10 (which is really a > > MINGW64 > > install), I got the following failure the first time I ran a build > > (before trying plain Windows, as opposed to git bash): > > > > mvn clean verify -P '!use-toolchains' > > ... > > [INFO] Running > > org.apache.hc.core5.concurrent.DefaultThreadFactoryTest > > [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time > > elapsed: 0.171 s <<< FAILURE! - in > > org.apache.hc.core5.concurrent.DefaultThreadFactoryTest > > [ERROR] > > org.apache.hc.core5.concurrent.DefaultThreadFactoryTest.newThread > > Time elapsed: 0.163 s <<< FAILURE! > > org.opentest4j.AssertionFailedError: expected: <true> but was: > > <false> > > at > > org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailur > > eB > > uilder.java:151) > > at > > org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(Asserti > > on > > FailureBuilder.java:132) > > at > > org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63) > > at > > org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36) > > at > > org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31) > > at > > org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:180) > > at > > org.apache.hc.core5.concurrent.DefaultThreadFactoryTest.newThread(D > > ef > > aultThreadFactoryTest.java:45) > > at > > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Nat > > iv > > e Method) > > at > > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Nati > > ve > > MethodAccessorImpl.java:77) > > at > > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke( > > De > > legatingMethodAccessorImpl.java:43) > > at > > java.base/java.lang.reflect.Method.invoke(Method.java:568) > > > > I build HC from source on a daily basis. I have an Ubuntu Linux and a > Windows 11 machines that I use regularly to work on HC. I have never > seen this one. I will take a look. > > > > After that I build again, got past that error, but then got: > > > > [ERROR] Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time > > elapsed: 60.27 s <<< FAILURE! - in > > org.apache.hc.core5.http.nio.support.classic.TestSharedOutputBuffer > > [ERROR] > > org.apache.hc.core5.http.nio.support.classic.TestSharedOutputBuffer > > .t > > estMultithreadingWriteStream Time elapsed: 60.013 s <<< ERROR! > > java.util.concurrent.TimeoutException > > at > > java.base/java.util.concurrent.FutureTask.get(FutureTask.java:204) > > at > > org.apache.hc.core5.http.nio.support.classic.TestSharedOutputBuffer > > .t > > estMultithreadingWriteStream(TestSharedOutputBuffer.java:177) > > at > > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Nat > > iv > > e Method) > > at > > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Nati > > ve > > MethodAccessorImpl.java:77) > > at > > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke( > > De > > legatingMethodAccessorImpl.java:43) > > at > > java.base/java.lang.reflect.Method.invoke(Method.java:568) > > > > I have seen this one once or twice in GibHub actions, but I was never > able to reproduce it locally. > > Test cases that involve multiple threads are finicky. > >
I believe I have fixed both test cases in master and 5.2.x Oleg --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
