+1

Tested src zip
- ASC OK
- SHA512 OK; shasum --check now works! :)
- On Windows, tested: mvn clean verify -P !use-toolchains

BUT using git's bash install on Windows 10 (which is really a MINGW64 install), 
I got the following failure the first time I ran a build (before trying plain 
Windows, as opposed to git bash):

mvn clean verify -P '!use-toolchains'
...
[INFO] Running org.apache.hc.core5.concurrent.DefaultThreadFactoryTest
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.171 s 
<<< FAILURE! - in org.apache.hc.core5.concurrent.DefaultThreadFactoryTest
[ERROR] org.apache.hc.core5.concurrent.DefaultThreadFactoryTest.newThread  Time 
elapsed: 0.163 s  <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
        at 
org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
        at 
org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
        at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
        at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
        at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31)
        at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:180)
        at 
org.apache.hc.core5.concurrent.DefaultThreadFactoryTest.newThread(DefaultThreadFactoryTest.java:45)
        at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
        at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:568)

After that I build again, got past that error, but then got:

[ERROR] Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 60.27 s 
<<< FAILURE! - in 
org.apache.hc.core5.http.nio.support.classic.TestSharedOutputBuffer
[ERROR] 
org.apache.hc.core5.http.nio.support.classic.TestSharedOutputBuffer.testMultithreadingWriteStream
  Time elapsed: 60.013 s  <<< ERROR!
java.util.concurrent.TimeoutException
        at java.base/java.util.concurrent.FutureTask.get(FutureTask.java:204)
        at 
org.apache.hc.core5.http.nio.support.classic.TestSharedOutputBuffer.testMultithreadingWriteStream(TestSharedOutputBuffer.java:177)
        at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
        at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:568)

So there is something special about building from the git bash command line.

The third build ran all the way through OK :)

Using:

Apache Maven 3.9.8 (36645f6c9b5079805ea5009217e36f2cffd34256)
Maven home: C:\java\apache-maven-3.9.8
Java version: 17.0.11, vendor: Eclipse Adoptium, runtime: C:\Program 
Files\Eclipse Adoptium\jdk-17.0.11.9-hotspot
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Gary

On 2024/06/27 08:25:37 Oleg Kalnichevski wrote:
> Please vote on releasing these packages as HttpCore 5.2.5.
> The vote is open for the at least 72 hours, and only votes from
> HttpComponents PMC members are binding. The vote passes if at least
> three binding +1 votes are cast and there are more +1 than -1 votes.
> 
> Release notes:
>  
> https://dist.apache.org/repos/dist/dev/httpcomponents/httpcore-5.2.5-RC1/RELEASE_NOTES-5.2.x.txt
> 
> Maven artefacts:
>  [link]
> 
> Git Tag: 5.2.5-RC1
>  https://github.com/apache/httpcomponents-core/tree/5.2.5-RC1
> 
> Packages:
>  https://dist.apache.org/repos/dist/dev/httpcomponents/httpcore-5.2.5-RC1
>  revision 70012
> 
> Hashes:
>  
> b06a33d4e33cdf5c46cccc0dcc9679ba3090d16c0d18dfc338b1fead08446469de3d24b2995b5bf1ab241f65a5493b21bb2443d98fde6e1a5848718aeeaabfb7
>  *httpcomponents-core-5.2.5-src.tar.gz httpcomponents-core-5.2.5-src.tar.gz
>  
> 7eeee78b2f90de1939eaf77f74d4384235df0e6645801a585d2c6b2f70fa4b9703710d8a30515e7a437ad228edc8937c622e1d3f4dd30fecdaee83551a661f3c
>  *httpcomponents-core-5.2.5-bin.tar.gz httpcomponents-core-5.2.5-bin.tar.gz
>  
> f097f8f0b820efccdb8338f79eb1172eaf34c5f69e9235c3652fb61a176aed3e8d0b23d56a61d321f8823a05b95a3700b4fc71c3dfd22afb5f84239bdd681da8
>  *httpcomponents-core-5.2.5-src.zip httpcomponents-core-5.2.5-src.zip
>  
> 91a4034cddd9fa7c9b7a12a6ecc85f746efca81088df9a0ca9e7d3ab7531f76cd6fecb55d4c314083beb1a202128f1f20ad6aef991cf60c3038e702477df1e39
>  *httpcomponents-core-5.2.5-bin.zip httpcomponents-core-5.2.5-bin.zip
> 
> Keys:
>  https://www.apache.org/dist/httpcomponents/httpcore/KEYS
> 
> --------------------------------------------------------------------------
> Vote: HttpCore 5.2.5 release
> [ ] +1 Release the packages as HttpCore 5.2.5.
> [ ] -1 I am against releasing the packages (must include a reason).
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
> For additional commands, e-mail: dev-h...@hc.apache.org
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

Reply via email to