[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821848#comment-17821848
 ] 

Konrad Windszus commented on HTTPCLIENT-2320:
---------------------------------------------

[~jsedding] I see that the original logic of selecting a proxy was modified in 
https://issues.apache.org/jira/browse/HTTPCLIENT-1710. Initially only the first 
config was considered (which is weird as well) but afterwards still the first 
proxy config is taken except if any other proxy config has an exception (in 
which case not proxy config is taken). I am pretty sure that supporting 
multiple proxy configs was a mistake (as those only allow to define exclude 
lists, but not include lists), which makes it impossible to determine which 
configuration is the one which should be applied for a certain request.

> Support IPv6 proxy exceptions in OSGiHttpRoutePlanner
> -----------------------------------------------------
>
>                 Key: HTTPCLIENT-2320
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2320
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient (classic)
>    Affects Versions: 4.5.15
>            Reporter: Konrad Windszus
>            Priority: Minor
>
> The code in 
> https://github.com/apache/httpcomponents-client/blob/54900db4653d7f207477e6ee40135b88e9bcf832/httpclient-osgi/src/main/java/org/apache/http/osgi/impl/OSGiHttpRoutePlanner.java#L67
>  can only correctly deal with host name, domain name or IPv4 address 
> exceptions. This is due to the fact that the inner class {{NetworkAddress}} 
> only parses IPv4 format address specs (and only stores the address internally 
> in an int = 32 bit) 
> (https://github.com/apache/httpcomponents-client/blob/54900db4653d7f207477e6ee40135b88e9bcf832/httpclient-osgi/src/main/java/org/apache/http/osgi/impl/OSGiHttpRoutePlanner.java#L154-L177)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

Reply via email to