HappyHacker123 commented on PR #500: URL: https://github.com/apache/httpcomponents-client/pull/500#issuecomment-1790736706
> This project by itself for testing, I think this change is redundant. Thanks for your reply :) . However, I think how downstream users use this project wouldn't hinder keeping a clean dependency tree. As maven official document goes, dependencies used for tests should be in test scope. Setting slf4j-api to test scope seems to do no harm. What's more, declaring a dependency as "test" scope means that the dependency won't be transitive according to maven doc, which means that this dependency won't be propogated to downstream users that use this project, even if the project is used for test by downstream projects. Scope "compile" is just the other way round. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
