HappyHacker123 opened a new pull request, #500:
URL: https://github.com/apache/httpcomponents-client/pull/500
# Problem Description
The slf4j-api is declared without assigning a dependency scope, leading to a
default scope compile. But it's only used for testing with classes
[org.slf4j.Logger, org.slf4j.LoggerFactory] in file “TypeAsyncResources.java"
and "TestClientResources.java".
```
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
</dependency>
```
# Possible Outcome
This brings redundant compile time dependency for the module, increasing the
probability of dependency conflict for downstream users.
# Solution
Changing the dependency scope to test can help. After changing the
dependency scope to "test," I recompiled the module and executed the tests.
Following these adjustments, the module compiled successfully, and all the
tests passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
