ok2c commented on code in PR #464:
URL:
https://github.com/apache/httpcomponents-client/pull/464#discussion_r1244852899
##########
httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/AsyncCachingExec.java:
##########
@@ -498,22 +502,24 @@ public void cancelled() {
storeRequestIfModifiedSinceFor304Response(request,
backendResponse);
} else {
LOG.debug("Backend response is not cacheable");
- responseCache.flushCacheEntriesFor(target, request, new
FutureCallback<Boolean>() {
+ if (!Method.isSafe(request.getMethod())) {
Review Comment:
@arturobernalg I am not sure. I do not think this is a cache storage layer
decision whether a method is considered safe or not. But let's discuss it when
I finish refactoring the cache eviction logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
