ok2c commented on code in PR #464:
URL:
https://github.com/apache/httpcomponents-client/pull/464#discussion_r1244817938
##########
httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/CacheMatch.java:
##########
@@ -26,30 +26,26 @@
*/
package org.apache.hc.client5.http.impl.cache;
-import org.apache.hc.client5.http.cache.HttpCacheEntry;
-
-/** Records a set of information describing a cached variant. */
-class Variant {
-
- private final String cacheKey;
- private final HttpCacheEntry entry;
-
- public Variant(final String cacheKey, final HttpCacheEntry entry) {
- this.cacheKey = cacheKey;
- this.entry = entry;
- }
+/**
+ * Represents a full match or a partial match (variant options)
+ * result of a cache lookup operation.
+ */
+class CacheMatch {
- public String getCacheKey() {
- return cacheKey;
- }
+ final CacheHit hit;
Review Comment:
@arturobernalg It is. All its instance variables are final and immutable.
There are no access methods but that does not make the class mutable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
