Comment re: URIBuilder: http://code.google.com/p/fluent-hc/wiki/UriBuilder

I'd suggest changing cloneURI to `builder.from("http://existing/uri";)`.
Also the URIBuilder constructor should take an existing URI object or string
URI as the initial URI to build upon.

Are values URL-encoded by the builder or are they assumed to already be
encoded?  You should allow the ability to do both, either by duplicate
methods like `setPathEscaped` or some funky switching like

builder
  .escaped()
  .setPath("monty%20python")
  .unescaped()
  .addParameter("q","what is your name?")


On Wed, Jun 1, 2011 at 11:40 AM, Xu, Lilu <cooki...@gmail.com> wrote:

> Hi,
>
> I almost finished the request execution module and most classes have been
> re-designed. Please have a look at the wiki pages [1] of this project and
> drop me some comments.
> The wiki pages contain some simple examples to illustrate how to use the
> facade API of httpclient.
>
> [1] http://code.google.com/p/fluent-hc/w/list
> --
> Best regards,
> Lilu
>

Reply via email to