[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599626#action_12599626
 ] 

Sebb commented on HTTPCLIENT-745:
---------------------------------

Agreed - apart from the issue of encapsulation, shared variables (if not final) 
are generally not thread-safe.

> no classes with default visibility
> ----------------------------------
>
>                 Key: HTTPCLIENT-745
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-745
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>            Reporter: Roland Weber
>            Priority: Minor
>             Fix For: 4.0 Beta 1
>
>
> There should be no classes with default (package) visibility. They cause 
> problems when classes using them are extended. All classes should either be 
> public, or nested with protected visibility where they are used. Nesting with 
> private visibility may be acceptable in certain cases, for example in final 
> classes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to