Agreed. Only just saw your PR <https://github.com/apache/groovy/pull/2272>.
Looks like the test case should cover the same ground, so I'd prefer
backporting that as well.

On Tue, Jul 22, 2025 at 2:51 PM Milles, Eric (TR Technology) via dev <
dev@groovy.apache.org> wrote:

> If 4.0.28 is not to be re-rolled, then I would prefer to backport the
> exception handling instead.
>
>
> ------------------------------
> *From:* Jonny <jonteh1...@gmail.com>
> *Sent:* Tuesday, July 22, 2025 2:42 PM
> *To:* dev@groovy.apache.org <dev@groovy.apache.org>
> *Subject:* Re: [EXT] Re: [VOTE] Release Apache Groovy 4.0.28 (Take 2)
>
> I've got a revert PR
> <https://urldefense.com/v3/__https://github.com/apache/groovy/pull/2271__;!!GFN0sa3rsbfR8OLyAw!btgHzsPM5gNQ2HTPUiq67knHDkwjxohzmkfLeviQPd62CzFMtg9c67LWwCM7vBGituQif0x2IbZ1QTcy2FIBFWyxew$>
>  up
> for the 4.0.x branch and am working on one for 3.x at Eric's suggestion.
>
> Two questions:
> 1. Do I need to wait on formal approval before merging? I am adding a
> test here
> <https://urldefense.com/v3/__https://github.com/apache/groovy/pull/2271/files*diff-5247172c04d2a0ddd377ce298baabe70a9f72d21efc3e764e63e2b9fc6c80ad3__;Iw!!GFN0sa3rsbfR8OLyAw!btgHzsPM5gNQ2HTPUiq67knHDkwjxohzmkfLeviQPd62CzFMtg9c67LWwCM7vBGituQif0x2IbZ1QTcy2FK3O7iCXQ$>,
> so there is new code, in addition to the revert.
> 2. Is it fair to assume that 4.0.28 will go out as-is, and this revert
> will be in 4.0.29?
>
> Best,
>
> Jonny
>
> On Tue, Jul 22, 2025 at 11:37 AM Jochen Theodorou <blackd...@gmx.org>
> wrote:
>
> Ha, I knew there is more behind this, my thanks to Jonny and Eric
>
> On 22.07.25 15:53, Milles, Eric (TR Technology) via dev wrote:
> > There is an exception as part of ResolveVisitor#visitField, which leaves
> > the class in a poor state.  I will have a fix today.
> >
> > In terms of 4.x, the original commit could be reverted as the bug fix is
> > not that high priority.
> >
> >
> > ------------------------------------------------------------------------
> > *From:* Jonny <jonteh1...@gmail.com>
> > *Sent:* Monday, July 21, 2025 4:43 PM
> > *To:* dev@groovy.apache.org <dev@groovy.apache.org>
> > *Subject:* [EXT] Re: [VOTE] Release Apache Groovy 4.0.28 (Take 2)
> > *External Email:* Use caution with links and attachments.
> >
> >
> > You got it, Paul. GROOVY-11719
> > <
> https://urldefense.com/v3/__https://issues.apache.org/jira/browse/GROOVY-11719__;!!GFN0sa3rsbfR8OLyAw!Z080OZm2KpECXoNtEGSKUN9FtnQwG6h3qExnoyWBiwYJInMuzJrueXrJNuL93Z1LYq7dd-w8hQDTksLQuG01VsU6Ug$>
>  raised.
> Thanks!
> >
> > On Mon, Jul 21, 2025 at 4:35 PM Paul King <pa...@asert.com.au
> > <mailto:pa...@asert.com.au>> wrote:
> >
> >     Hi Jonny,
> >
> >     Can you create a Jira ticket please? I don't plan to re-roll the
> >     release at this stage and we can fix it in the next release, but
> >     I'll await any further comments from Daniel/Eric who seem to be
> >     involved in earlier commits.
> >
> >     Cheers, Paul.
> >
> >
> >     On Tue, Jul 22, 2025 at 7:08 AM Jonny <jonny...@apache.org
> >     <mailto:jonny...@apache.org>> wrote:
> >
> >         I've traced the issue back
> >         to 33064484cc043bfb7c2ad75ee8fccbcbc6329b76. I think I've hit
> >         upon a fix
> >         <
> https://urldefense.com/v3/__https://github.com/apache/groovy/pull/2270__;!!GFN0sa3rsbfR8OLyAw!Z080OZm2KpECXoNtEGSKUN9FtnQwG6h3qExnoyWBiwYJInMuzJrueXrJNuL93Z1LYq7dd-w8hQDTksLQuG1fYguDCg$>,
> pending review. Apologies for doing this on the release thread. Feel free
> to tell me that I'm out of order or just need to wait for the next release
> train. 😅
> >
> >         On Mon, Jul 21, 2025 at 3:38 PM Jonny <jonny...@apache.org
> >         <mailto:jonny...@apache.org>> wrote:
> >
> >             Trying out the latest snapshot for 4.0.28, I'm encountering
> >             an error locally in my company's app's test suite. Based on
> >             the origin of the tests, this seems to be a regression of
> >             GROOVY-9526
> >             <
> https://urldefense.com/v3/__https://issues.apache.org/jira/browse/GROOVY-9526__;!!GFN0sa3rsbfR8OLyAw!Z080OZm2KpECXoNtEGSKUN9FtnQwG6h3qExnoyWBiwYJInMuzJrueXrJNuL93Z1LYq7dd-w8hQDTksLQuG2LrvKWRw$>,
> or at least in that vicinity.
> >
> >             I've created a test (similar to the one we had in our app),
> >             which demonstrates the problem.
> >
> https://github.com/apache/groovy/compare/GROOVY_4_0_X...jonnybot0:groovy:GROOVY-9526-regression-semantic-analysis-exception?expand=1
> <https://urldefense.com/v3/__https://github.com/apache/groovy/compare/GROOVY_4_0_X...jonnybot0:groovy:GROOVY-9526-regression-semantic-analysis-exception?expand=1__;!!GFN0sa3rsbfR8OLyAw!btgHzsPM5gNQ2HTPUiq67knHDkwjxohzmkfLeviQPd62CzFMtg9c67LWwCM7vBGituQif0x2IbZ1QTcy2FJUgS6q9w$>
>  <
> https://urldefense.com/v3/__https://github.com/apache/groovy/compare/GROOVY_4_0_X...jonnybot0:groovy:GROOVY-9526-regression-semantic-analysis-exception?expand=1__;!!GFN0sa3rsbfR8OLyAw!Z080OZm2KpECXoNtEGSKUN9FtnQwG6h3qExnoyWBiwYJInMuzJrueXrJNuL93Z1LYq7dd-w8hQDTksLQuG3yO6Hs2Q$
> >
> >
> >             This was not failing as recently as a week or two ago, so I
> >             suspect it's a relatively recent change.
> >
> >             I'm open to being told that the semantics I'm using in this
> >             test are truly just invalid and unsupported, but I'll need
> >             some clearer idea /why/ they are, as we may need to pass
> >             some guidance on to our users.
> >
> >             Trying to raise this before release in case it's an easy fix.
> >
> >
> >             On Mon, Jul 21, 2025 at 1:24 PM Milles, Eric (TR Technology)
> >             via dev <dev@groovy.apache.org
> >             <mailto:dev@groovy.apache.org>> wrote:
> >
> >                 +1 (binding)
> >
> >
>  ------------------------------------------------------------------------
> >                 *From:* Paul King <pa...@asert.com.au
> >                 <mailto:pa...@asert.com.au>>
> >                 *Sent:* Sunday, July 20, 2025 5:45 AM
> >                 *To:* Groovy_Developers <dev@groovy.apache.org
> >                 <mailto:dev@groovy.apache.org>>
> >                 *Subject:* [EXT] [VOTE] Release Apache Groovy 4.0.28
> >                 (Take 2)
> >                 *External Email:* Use caution with links and attachments.
> >
> >
> >
> >                 Dear development community,
> >
> >                 I am happy to start the VOTE thread for a Groovy 4.0.28
> >                 release!
> >
> >                 This release includes 19 bug fixes/improvements as
> >                 outlined in the changelog:
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12355971
> <https://urldefense.com/v3/__https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12355971__;!!GFN0sa3rsbfR8OLyAw!btgHzsPM5gNQ2HTPUiq67knHDkwjxohzmkfLeviQPd62CzFMtg9c67LWwCM7vBGituQif0x2IbZ1QTcy2FL8yVGkXg$>
>  <
> https://urldefense.com/v3/__https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12355971__;!!GFN0sa3rsbfR8OLyAw!fvFuM-SRUpSaaLUHSSfvsP2YIgTH2TFKF_YrP6xqsqicrylv3_I8pvEkEVRyOcAlLLSjZ8JsbO95wFXtjuJpCA$
> >
> >
> >                 Tag:
> >
> https://gitbox.apache.org/repos/asf?p=groovy.git;a=tag;h=refs/tags/GROOVY_4_0_28
> <https://urldefense.com/v3/__https://gitbox.apache.org/repos/asf?p=groovy.git;a=tag;h=refs*tags*GROOVY_4_0_28__;Ly8!!GFN0sa3rsbfR8OLyAw!btgHzsPM5gNQ2HTPUiq67knHDkwjxohzmkfLeviQPd62CzFMtg9c67LWwCM7vBGituQif0x2IbZ1QTcy2FI9bXgx0g$>
>  <
> https://urldefense.com/v3/__https://gitbox.apache.org/repos/asf?p=groovy.git;a=tag;h=refs*tags*GROOVY_4_0_28__;Ly8!!GFN0sa3rsbfR8OLyAw!fvFuM-SRUpSaaLUHSSfvsP2YIgTH2TFKF_YrP6xqsqicrylv3_I8pvEkEVRyOcAlLLSjZ8JsbO95wFW7LMEnig$
> >
> >                 Tag commit id: bc6204944686858db9c6f195909f2258ad1d2a62
> >
> >                 The artifacts to be voted on are located as follows
> >                 (r78267).
> >                 Source release:
> >
> https://dist.apache.org/repos/dist/dev/groovy/4.0.28/sources
> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/groovy/4.0.28/sources__;!!GFN0sa3rsbfR8OLyAw!btgHzsPM5gNQ2HTPUiq67knHDkwjxohzmkfLeviQPd62CzFMtg9c67LWwCM7vBGituQif0x2IbZ1QTcy2FK_sHCOvQ$>
>  <
> https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/groovy/4.0.28/sources__;!!GFN0sa3rsbfR8OLyAw!fvFuM-SRUpSaaLUHSSfvsP2YIgTH2TFKF_YrP6xqsqicrylv3_I8pvEkEVRyOcAlLLSjZ8JsbO95wFWv2nPY5Q$
> >
> >                 Convenience binaries:
> >
> https://dist.apache.org/repos/dist/dev/groovy/4.0.28/distribution
> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/groovy/4.0.28/distribution__;!!GFN0sa3rsbfR8OLyAw!btgHzsPM5gNQ2HTPUiq67knHDkwjxohzmkfLeviQPd62CzFMtg9c67LWwCM7vBGituQif0x2IbZ1QTcy2FJXZ_Id1w$>
>  <
> https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/groovy/4.0.28/distribution__;!!GFN0sa3rsbfR8OLyAw!fvFuM-SRUpSaaLUHSSfvsP2YIgTH2TFKF_YrP6xqsqicrylv3_I8pvEkEVRyOcAlLLSjZ8JsbO95wFUl-otI_w$
> >
> >
> >                 Release artifacts are signed with a key from the
> >                 following file:
> >                 https://dist.apache.org/repos/dist/release/groovy/KEYS
> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/release/groovy/KEYS__;!!GFN0sa3rsbfR8OLyAw!btgHzsPM5gNQ2HTPUiq67knHDkwjxohzmkfLeviQPd62CzFMtg9c67LWwCM7vBGituQif0x2IbZ1QTcy2FJNFg2qvw$>
> >                 <
> https://urldefense.com/v3/__https://dist.apache.org/repos/dist/release/groovy/KEYS__;!!GFN0sa3rsbfR8OLyAw!fvFuM-SRUpSaaLUHSSfvsP2YIgTH2TFKF_YrP6xqsqicrylv3_I8pvEkEVRyOcAlLLSjZ8JsbO95wFW7lBIg0Q$
> >
> >
> >                 Please vote on releasing this package as Apache Groovy
> >                 4.0.28.
> >
> >                 Reminder on ASF release approval requirements for PMC
> >                 members:
> >
> http://www.apache.org/legal/release-policy.html#release-approval
> <https://urldefense.com/v3/__http://www.apache.org/legal/release-policy.html*release-approval__;Iw!!GFN0sa3rsbfR8OLyAw!btgHzsPM5gNQ2HTPUiq67knHDkwjxohzmkfLeviQPd62CzFMtg9c67LWwCM7vBGituQif0x2IbZ1QTcy2FL1Yo_8eg$>
>  <
> https://urldefense.com/v3/__http://www.apache.org/legal/release-policy.html*release-approval__;Iw!!GFN0sa3rsbfR8OLyAw!fvFuM-SRUpSaaLUHSSfvsP2YIgTH2TFKF_YrP6xqsqicrylv3_I8pvEkEVRyOcAlLLSjZ8JsbO95wFUegGEwiw$
> >
> >                 Hints on validating checksums/signatures (but replace
> >                 md5sum with sha256sum):
> >                 https://www.apache.org/info/verification.html
> <https://urldefense.com/v3/__https://www.apache.org/info/verification.html__;!!GFN0sa3rsbfR8OLyAw!btgHzsPM5gNQ2HTPUiq67knHDkwjxohzmkfLeviQPd62CzFMtg9c67LWwCM7vBGituQif0x2IbZ1QTcy2FJihD80gg$>
> >                 <
> https://urldefense.com/v3/__https://www.apache.org/info/verification.html__;!!GFN0sa3rsbfR8OLyAw!fvFuM-SRUpSaaLUHSSfvsP2YIgTH2TFKF_YrP6xqsqicrylv3_I8pvEkEVRyOcAlLLSjZ8JsbO95wFUZ9EcRCw$
> >
> >
> >                 The vote is open for the next 72 hours and passes if a
> >                 majority of at least three +1 PMC votes are cast.
> >
> >                 [ ] +1 Release Apache Groovy 4.0.28
> >                 [ ]  0 I don't have a strong opinion about this, but I
> >                 assume it's ok
> >                 [ ] -1 Do not release Apache Groovy 4.0.28 because...
> >
> >                 Here is my vote:
> >
> >                 +1 (binding)
> >
>
>

Reply via email to