Hi Paul,
understood, thanks.
Jan
On 5/7/19 11:17 AM, Paul King wrote:
PR884 made it into the 2.5 and 3 .0 beta releases but not the 2.4
release. The 2.4 branch is in low maintenance mode. I.e. only critical
fixes or low risk cosmetic changes. We won't re-roll the 2.5/3
releases for PRs 923 & 924 but we'll take a look and merge when we get
the chance if they make sense. New releases shouldn't be too far away
and sometimes voting highlights more major things that require
re-rolling the releases and re-starting the voting.
Cheers, Paul.
On Tue, May 7, 2019 at 6:29 PM Jan Lukavský <je...@seznam.cz
<mailto:je...@seznam.cz>> wrote:
Thanks Andres,
sorry for that, Paul merged that (and probably rebased). I'm very,
very sorry about my absolutely late activity, but I forgot one
last thing that would make my life easier:
https://issues.apache.org/jira/browse/GROOVY-9109
with PRs:
https://github.com/apache/groovy/pull/924
https://github.com/apache/groovy/pull/923
I understand, that the release vote is already running, so if this
needs some more discussion, or it is already just too late, then I
understand.
Many thanks,
Jan
On 5/6/19 8:54 PM, Andres Almiray wrote:
Jan,
PR 884 targets master branch which stands for Groovy 3.
This release is for Groovy 2.4.7 which means the PR needs to be
rebased and target the GROOVY_2_4_X branch.
Cheers,
Andres
-------------------------------------------
Java Champion; Groovy Enthusiast
JCP EC Associate Seat
http://andresalmiray.com
http://www.linkedin.com/in/aalmiray
--
What goes up, must come down. Ask any system administrator.
There are 10 types of people in the world: Those who understand
binary, and those who don't.
To understand recursion, we must first understand recursion.
On Mon, May 6, 2019 at 8:44 PM Jan Lukavský <je...@seznam.cz
<mailto:je...@seznam.cz>> wrote:
Hi,
I know that it might be already a little late, but (if I
didn't miss anything) nobody commented on PR [1].
Any chance it could make it into the planned release?
Thanks for comments,
Jan
[1] https://github.com/apache/groovy/pull/884
On 5/6/19 6:30 PM, Paul King wrote:
We should see if we can make our tests Locale independent if
we can for next time. Can you at least log it in Jira.
Thanks.
On Tue, May 7, 2019 at 2:19 AM Daniel.Sun <sun...@apache.org
<mailto:sun...@apache.org>> wrote:
+1 (binding)
Here is the result of build scan:
https://gradle.com/s/j72ywyaymcvri
There is a failed test because of locale, so I think it
is still OK to
release.
Cheers,
Daniel.Sun
-----
Apache Groovy committer & PMC member
Blog: http://blog.sunlan.me
Twitter: @daniel_sun
--
Sent from:
http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html
