Jan, PR 884 targets master branch which stands for Groovy 3. This release is for Groovy 2.4.7 which means the PR needs to be rebased and target the GROOVY_2_4_X branch.
Cheers, Andres ------------------------------------------- Java Champion; Groovy Enthusiast JCP EC Associate Seat http://andresalmiray.com http://www.linkedin.com/in/aalmiray -- What goes up, must come down. Ask any system administrator. There are 10 types of people in the world: Those who understand binary, and those who don't. To understand recursion, we must first understand recursion. On Mon, May 6, 2019 at 8:44 PM Jan Lukavský <je...@seznam.cz> wrote: > Hi, > > I know that it might be already a little late, but (if I didn't miss > anything) nobody commented on PR [1]. > > Any chance it could make it into the planned release? > > Thanks for comments, > > Jan > > [1] https://github.com/apache/groovy/pull/884 > On 5/6/19 6:30 PM, Paul King wrote: > > We should see if we can make our tests Locale independent if we can for > next time. Can you at least log it in Jira. > > Thanks. > > On Tue, May 7, 2019 at 2:19 AM Daniel.Sun <sun...@apache.org> wrote: > >> >> +1 (binding) >> >> Here is the result of build scan: >> https://gradle.com/s/j72ywyaymcvri >> >> There is a failed test because of locale, so I think it is still OK to >> release. >> >> Cheers, >> Daniel.Sun >> >> >> >> ----- >> Apache Groovy committer & PMC member >> Blog: http://blog.sunlan.me >> Twitter: @daniel_sun >> >> -- >> Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html >> >
