+1 (binding)

I checked:
etc/bin/verify.sh orgapachegrails-1053 v7.0.0-M4

That does
* name checking
* finding that NOTICE, LICENSE and DISCLAIMER files exists
* Verify checksums
* Build from source

The only thing that did not work was reproducible builds, but that is AFAIK
a known bug, and I will work with James Daughety if this is an issue.




Den ons. 4. jun. 2025 kl. 13.37 skrev Paul King <pa...@asert.com.au>:

> +1 paulk (binding)
>
> I checked:
> * "incubating" in distribution file names
> * NOTICE, LICENSE and DISCLAIMER files exist
> * No unexpected binary files in src zip
> * Verified signatures and checksums for all zips
> * Gradle bootstrap for src zip using: "gradle -p gradle-bootstrap" (I
> used gradle 8.11)
> * Build from source: "./gradlew build -PskipTests"
> * Build from source for grails-forge: as above
>   (used MacOS this time and didn't get spotless complaints)
> * I note the xsd/dtd CDDL licenses which normally wouldn't be in a source
>   distribution but are allowed "by virtue of being specified by a standard"
>   for a small number of files as per tomcat src release
> * For next release, please give more attention to NOTICE/LICENSE files
> in jar artifacts
> * Just the known "grails-forge/.gitattributes" error from the RAT report
> * I tried:
>   ./grails-forge-cli-help
>   ./grails-forge-cli create-app hello
>   ./grails-forge-cli --version
>   ./grails-shell-cli --version
> * I think additional guidance in the vote email on what to read to
> build from src would be useful for newbies
>
> Cheers, Paul.
>
> On Wed, Jun 4, 2025 at 6:45 PM James Daugherty
> <jdaughe...@jdresources.net.invalid> wrote:
> >
> > Hi Everyone,
> >
> > We have fixed the shell CLI issue with profiles & dynamic command lookups
> > so I am happy to start the new VOTE thread for an Apache Grails
> > (incubating) release of version 7.0.0-M4!
> >
> > Please note that most of the reported feedback from the initial stage has
> > been fixed.  The one exception is there is a missing
> > `.gitattribute` exclude on the RAT config.  The plan is to fix that in
> the
> > next milestone.
> >
> > This release is our first release under the ASF. Further details of the
> > release can be found on the GitHub pre-release & in the discussion thread
> > at:
> > https://lists.apache.org/thread/3tqw39b1v542rc026gopj0kbqs5zbr5q
> >
> > Releases for the Grails project consist of 2 repositories, so there are
> two
> > tags:
> > grails-core Tag:
> > https://github.com/apache/grails-core/releases/tag/v7.0.0-M4
> > Tag commit id: 57cc53fbce100f5b1df8cf6ea5acf4815cd4ca98
> >
> > grails-forge Tag:
> > https://github.com/apache/grails-forge/releases/tag/v7.0.0-M4
> > Tag commit id: 4f893e4fc52ccfbce18281b57e463f7fd4ce27a9
> >
> > The artifacts to be voted on are located as follows (rr77366):
> > Source release:
> > https://dist.apache.org/repos/dist/dev/grails/core/7.0.0-M4/sources
> > Binary distributions:
> > https://dist.apache.org/repos/dist/dev/grails/core/7.0.0-M4/distribution
> >
> > Release artifacts are signed with a key from the following file:
> > https://dist.apache.org/repos/dist/release/grails/KEYS
> >
> > Please vote on releasing this package as Apache Grails (incubating)
> > 7.0.0-M4.
> >
> > Reminder on ASF release approval requirements for PPMC members:
> > https://www.apache.org/legal/release-policy.html#release-approval
> >
> > Hints on validating checksums/signatures (but replace md5sum with
> > sha512sum):
> > https://www.apache.org/info/verification.html
> >
> > Details of our release process is documented at:
> > https://github.com/apache/grails-core/blob/7.0.x/RELEASE.md
> >
> > The vote is open for the next 72 hours and passes if a majority of at
> least
> > three +1 PPMC votes are cast.
> >
> > [ ] +1 Release Apache Grails (incubating) 7.0.0-M4
> > [ ]  0 I don't have a strong opinion about this, but I assume it's ok
> > [ ] -1 Do not release Apache Grails (incubating) 7.0.0-M4 because...
> >
> > Here is my vote:
> >
> > +1 (binding)
>


-- 

Med venlig hilsen,
Søren Berg Glasius

Hedevej 1, Gl. Rye, 8680 Ry
Mobile: +45 40 44 91 88
--- Press ESC once to quit - twice to save the changes.

Reply via email to