Hi Rui, After further discussion, on the CHI call this morning, we decided it is best to just leave the action and its current state (with the updated message). The GH Actions have their own state cache, so the action doesn't use the labels to tell what it marked as stale in the past.
To help out CHI's reviews, we do need to add the missing "stale" label to the few hundred PRs that were marked stale but not labelled. I am happy to write a script/manually update them, however I don't have the power to add labels to PRs. Is that something that can be granted to me on Github? Along those lines, it would be useful for those of us in the CHI to be able to label PRs with things like "ready-to-merge" (to help committers easily find low hanging fruit), "reviewed-by-chi" or similar. Would it be possible to give label edit writes to CHI members like myself and David Radley? I realise that might actually need a wider discussion on the ML. Thanks, Tom Cooper @tomncooper | tomcooper.dev On Thursday, 16 January 2025 at 01:40, Rui Fan <1996fan...@gmail.com> wrote: > Hi Tom and David, > > The Stale PR message isn't a big problem, I think we could ignore it for > the old PRs. > > I'm not sure if they will be closed after 90 days if some PR is not labeled > as 'stale'? > If yes, I think it's not a big problem, we could ignore it as well. > If not, we need to address it. > > WDYT? > > Best, > Rui > > > On Wed, Jan 15, 2025 at 9:50 PM Tom Cooper c...@tomcooper.dev wrote: > > > I think clearing the cache and re-running should work. > > > > However, there was an issue with the formatting of the Stale PR message > > (that got imported from the Apache Kafka version it is based on). I have > > fixed that in this PR [1], so if that can be merged first before clearing > > the cache that would be preferable. We may get some repeat comments. > > > > Thanks, > > > > Tom Cooper > > @tomncooper | tomcooper.dev > > > > [1] https://github.com/apache/flink/pull/25992 > > > > On Wednesday, 15 January 2025 at 12:20, David Radley < > > david_rad...@uk.ibm.com> wrote: > > > > > Hi Rui, > > > Looks good. I ran: > > > > https://github.com/apache/flink/pulls?q=is%3Apr+is%3Aopen+This+PR+is+being+marked+as+stale+since+it+has+not+had+any+activity+in+the+last+180+days > > . > > > > > And there are 610 open PRs. I am wondering how we get the stale label > > > onto those PRs. Some thoughts > > > > > > 1. We write batch script using the github API to make these changes > > > under a user that have authority to create labels. > > > 2. Rerun the stale bot with changes – so it loses its history somehow > > > and then it will reprocess everything adding the stale label. > > > 3. Remove the cache from the git action. > > > https://stackoverflow.com/questions/63521430/clear-cache-in-github-actions > > > > > > 3)Looks like a good option – WDYT? Could some with write access remove > > > the cache for the stale git action when it is not running? > > > > > > Kind regards, David. > > > > > > From: Rui Fan 1996fan...@gmail.com > > > > > > Date: Wednesday, 15 January 2025 at 07:00 > > > To: dev@flink.apache.org dev@flink.apache.org > > > > > > Subject: [EXTERNAL] Re: Stale PR Action running but the labels are > > > missing > > > It seems the stale label works for now. 124 PRs[1] were labeled as > > > 'stale' > > > in the fourth batch[2]. > > > > > > [1] > > > > https://github.com/apache/flink/labels/stale?page=5&q=is%3Aopen+label%3Astale > > > > > [2] https://github.com/apache/flink/actions/runs/12782496848 > > > > > > Best, > > > Rui > > > > > > On Wed, Jan 15, 2025 at 10:09 AM Rui Fan 1996fan...@gmail.com wrote: > > > > > > > Hi Tom, > > > > > > > > Thanks for following up and pointing it out! > > > > > > > > I just asked ChatGPT, it seems github bot doesn't create new labels > > > > and we need to create new labels in advance. > > > > > > > > I created 'stale' and 'closed-stale' label[1]s just now, let us > > > > see whether the label works for subsequent PRs. > > > > > > > > [1] https://github.com/apache/flink/labels?q=stale > > > > > > > > Best, > > > > Rui > > > > > > > > On Wed, Jan 15, 2025 at 1:23 AM Tom Cooper c...@tomcooper.dev wrote: > > > > > > > > > Hi all, > > > > > > > > > > We have enabled [1] the Stale PR GitHub action and it has starting > > > > > tagging PRs [2] with the specified comments (for example [3]). > > > > > > > > > > However, it is not applying the specified 'stale' label to the PRs. > > > > > The > > > > > docs don't say anything about needing to create the label first, but > > > > > I > > > > > wondered if there is some restriction in the repository settings or > > > > > on the > > > > > GITHUB TOKEN used by the action that prevents it creating the label? > > > > > If > > > > > someone with the required authority could check I would be greatful. > > > > > > > > > > Thanks, > > > > > > > > > > Tom Cooper > > > > > @tomncooper | tomcooper.dev > > > > > > > > > > [1] https://github.com/apache/flink/pull/25953 > > > > > [2] https://github.com/apache/flink/actions/runs/12767242530 > > > > > [3] > > > > > https://github.com/apache/flink/pull/3672#issuecomment-2589741128 > > > > > > Unless otherwise stated above: > > > > > > IBM United Kingdom Limited > > > Registered in England and Wales with number 741598 > > > Registered office: Building C, IBM Hursley Office, Hursley Park Road, > > > Winchester, Hampshire SO21 2JN
