Okay turns out that the upload script uses sed to extract the version and that doesn't work with Mac's sed. I will update the docs to reflect the need to use gsed for the release.
Because we didn't need to touch code to fix it, I'd leave the RC1 still active. Instead, I have deleted the old staging jars and replaced them by new ones [1] [2]. However, I'd reset all votes to 0. Everyone that already cast +1, can probably do a quick redo by just checking those staging jars. Thank you very much for your help and patience Arvid [1] https://repository.apache.org/content/repositories/staging/org/apache/flink/flink-connector-kafka/3.3.0-1.19/ [2] https://repository.apache.org/content/repositories/staging/org/apache/flink/flink-connector-kafka/3.3.0-1.20/ On Tue, Oct 15, 2024 at 8:21 AM Arvid Heise <ahe...@confluent.io> wrote: > That's a good catch Leonard. I'll check if I can change that on the fly or > else I will create a new RC. > > On Tue, Oct 15, 2024 at 7:56 AM Leonard Xu <xbjt...@gmail.com> wrote: > >> - verified signatures >> - verified hashsums >> - checked Github release tag >> - reviewed the web PR >> >> TODO: >> Quick question about the url before vote. >> >> >> https://repository.apache.org/content/repositories/staging/org/apache/flink/flink-connector-kafka/3.3.0-1.19.1 >> >> https://repository.apache.org/content/repositories/staging/org/apache/flink/flink-connector-kafka/3.3.0-1.19.1/flink-connector-kafka-3.3.0-1.19.1.jar >> >> The suffix of directory and file name should -1.19 instead of -1.19.1, >> the 1.19 means all supported flink versions like 1.19.0,1.19.1,1.19.2, etc. >> But a specific flink version >> -1.19.1will confuse users a lot that is this connector can be used for >> flink 1.19.2 ? >> >> >> Best, >> Leonard >> >> >> >> >> >> > 2024年10月14日 下午6:01，Ahmed Hamdy <hamdy10...@gmail.com> 写道： >> > >> > Hi Arvid, >> > yeah sure, thanks for following up >> > >> > Best Regards >> > Ahmed Hamdy >> > >> > >> > On Mon, 14 Oct 2024 at 10:52, Danny Cranmer <dannycran...@apache.org> >> wrote: >> > >> >> Hey Arvid, >> >> >> >> +1 (binding) >> >> >> >> - I left a couple of comments on the website PR that need addressing >> >> - Release notes look good >> >> - Source archive signatures and checksums are correct >> >> - There are no binaries in the source archive >> >> - Contents of mvn dist look good >> >> - Binary signatures and checksums are correct >> >> - CI build of tag successful [1] >> >> - NOTICE and LICENSE files look correct >> >> >> >> Thanks, >> >> Danny >> >> >> >> [1] >> >> >> https://github.com/apache/flink-connector-kafka/actions/runs/11281680238 >> >> >> >> On Mon, Oct 14, 2024 at 10:29 AM Arvid Heise <ar...@apache.org> wrote: >> >> >> >>> Hi Ahmed, >> >>> >> >>> thanks for pointing out that web PR looks amiss. I consulted with >> Chesnay >> >>> and it looks like our Hugo setup is not perfect. First, we didn't pin >> the >> >>> Hugo version, which I now did. But second it seems like we still get >> >>> different signature on the scripts for some reasons. I will not be >> able >> >> to >> >>> solve it and it seems to be ongoing for a while (history shows many of >> >>> these merge war conflicts). >> >>> >> >>> So I'm creating a follow-up ticket and leave as-is, okay? >> >>> >> >>> Best, >> >>> >> >>> Arvid >> >>> >> >>> On Sat, Oct 12, 2024 at 9:54 PM Ahmed Hamdy <hamdy10...@gmail.com> >> >> wrote: >> >>> >> >>>> HI Arvid, >> >>>> +1 (non-binding) >> >>>> >> >>>> - Checksum & signatures are correct >> >>>> - Build from source >> >>>> - Verified tag exists in github >> >>>> - Verified no binaries in release >> >>>> - Reviewed web PR, nit: The PR is in draft mode and I see we are >> >> touching >> >>>> index files on unrelated resources. Is this intended or did I miss >> >>>> something? >> >>>> >> >>>> >> >>>> Best Regards >> >>>> Ahmed Hamdy >> >>>> >> >>>> >> >>>> On Sat, 12 Oct 2024 at 05:23, Yanquan Lv <decq12y...@gmail.com> >> wrote: >> >>>> >> >>>>> +1 (non-binding) >> >>>>> I checked: >> >>>>> - Review JIRA release notes >> >>>>> - Verify hashes >> >>>>> - Verify signatures >> >>>>> - Build from source with JDK 8/11/17 >> >>>>> - Source code artifacts matching the current release >> >>>>> >> >>>>> >> >>>>> >> >>>>>> 2024年10月11日 23:33，Arvid Heise <ar...@apache.org> 写道： >> >>>>>> >> >>>>>> Hi everyone, >> >>>>>> >> >>>>>> >> >>>>>> Please review and vote on release candidate #1 for >> >>>> flink-connector-kafka >> >>>>>> v3.3.0, as follows: >> >>>>>> >> >>>>>> [ ] +1, Approve the release >> >>>>>> >> >>>>>> [ ] -1, Do not approve the release (please provide specific >> >> comments) >> >>>>>> >> >>>>>> >> >>>>>> >> >>>>>> >> >>>>>> >> >>>>>> The complete staging area is available for your review, which >> >>> includes: >> >>>>>> >> >>>>>> * JIRA release notes [1], >> >>>>>> >> >>>>>> * the official Apache source release to be deployed to >> >>> dist.apache.org >> >>>>> [2], >> >>>>>> which are signed with the key with fingerprint 538B49E9BCF0B72F >> >> [3], >> >>>>>> >> >>>>>> * all artifacts to be deployed to the Maven Central Repository [4], >> >>>>>> >> >>>>>> * source code tag v3.3.0-rc1 [5], >> >>>>>> >> >>>>>> * website pull request listing the new release [6]. >> >>>>>> >> >>>>>> * CI build of the tag [7]. >> >>>>>> >> >>>>>> >> >>>>>> >> >>>>>> The vote will be open for at least 72 hours. It is adopted by >> >>> majority >> >>>>>> approval, with at least 3 PMC affirmative votes. >> >>>>>> >> >>>>>> >> >>>>>> >> >>>>>> Thanks, >> >>>>>> >> >>>>>> Arvid Heise >> >>>>>> >> >>>>>> >> >>>>>> >> >>>>>> [1] >> >>>>>> >> >>>>> >> >>>> >> >>> >> >> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12354606 >> >>>>>> >> >>>>>> [2] >> >>>>>> >> >>>>> >> >>>> >> >>> >> >> >> https://dist.apache.org/repos/dist/dev/flink/flink-connector-kafka-3.3.0-rc1 >> >>>>>> >> >>>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS >> >>>>>> >> >>>>>> [4] >> >>>>>> >> >>>>> >> >>>> >> >>> >> >> >> https://repository.apache.org/content/repositories/staging/org/apache/flink/flink-connector-kafka/3.3.0-1.19.1/ >> >>>>>> + >> >>>>>> >> >>>>> >> >>>> >> >>> >> >> >> https://repository.apache.org/content/repositories/staging/org/apache/flink/flink-connector-kafka/3.3.0-1.20.0/ >> >>>>>> >> >>>>>> [5] >> >>>>> >> >>> >> https://github.com/apache/flink-connector-kafka/releases/tag/v3.3.0-rc1 >> >>>>>> >> >>>>>> [6] https://github.com/apache/flink-web/pull/757 >> >>>>>> >> >>>>>> [7] >> >>>>>> >> >>>>> >> >>>> >> >>> >> >> >> https://github.com/apache/flink-connector-kafka/actions/runs/11281680238/ >> >>>>> >> >>>>> >> >>>> >> >>> >> >> >> >>
