Hey Arvid, +1 (binding)
- I left a couple of comments on the website PR that need addressing - Release notes look good - Source archive signatures and checksums are correct - There are no binaries in the source archive - Contents of mvn dist look good - Binary signatures and checksums are correct - CI build of tag successful [1] - NOTICE and LICENSE files look correct Thanks, Danny [1] https://github.com/apache/flink-connector-kafka/actions/runs/11281680238 On Mon, Oct 14, 2024 at 10:29 AM Arvid Heise <ar...@apache.org> wrote: > Hi Ahmed, > > thanks for pointing out that web PR looks amiss. I consulted with Chesnay > and it looks like our Hugo setup is not perfect. First, we didn't pin the > Hugo version, which I now did. But second it seems like we still get > different signature on the scripts for some reasons. I will not be able to > solve it and it seems to be ongoing for a while (history shows many of > these merge war conflicts). > > So I'm creating a follow-up ticket and leave as-is, okay? > > Best, > > Arvid > > On Sat, Oct 12, 2024 at 9:54 PM Ahmed Hamdy <hamdy10...@gmail.com> wrote: > > > HI Arvid, > > +1 (non-binding) > > > > - Checksum & signatures are correct > > - Build from source > > - Verified tag exists in github > > - Verified no binaries in release > > - Reviewed web PR, nit: The PR is in draft mode and I see we are touching > > index files on unrelated resources. Is this intended or did I miss > > something? > > > > > > Best Regards > > Ahmed Hamdy > > > > > > On Sat, 12 Oct 2024 at 05:23, Yanquan Lv <decq12y...@gmail.com> wrote: > > > > > +1 (non-binding) > > > I checked: > > > - Review JIRA release notes > > > - Verify hashes > > > - Verify signatures > > > - Build from source with JDK 8/11/17 > > > - Source code artifacts matching the current release > > > > > > > > > > > > > 2024年10月11日 23:33，Arvid Heise <ar...@apache.org> 写道： > > > > > > > > Hi everyone, > > > > > > > > > > > > Please review and vote on release candidate #1 for > > flink-connector-kafka > > > > v3.3.0, as follows: > > > > > > > > [ ] +1, Approve the release > > > > > > > > [ ] -1, Do not approve the release (please provide specific comments) > > > > > > > > > > > > > > > > > > > > > > > > The complete staging area is available for your review, which > includes: > > > > > > > > * JIRA release notes [1], > > > > > > > > * the official Apache source release to be deployed to > dist.apache.org > > > [2], > > > > which are signed with the key with fingerprint 538B49E9BCF0B72F [3], > > > > > > > > * all artifacts to be deployed to the Maven Central Repository [4], > > > > > > > > * source code tag v3.3.0-rc1 [5], > > > > > > > > * website pull request listing the new release [6]. > > > > > > > > * CI build of the tag [7]. > > > > > > > > > > > > > > > > The vote will be open for at least 72 hours. It is adopted by > majority > > > > approval, with at least 3 PMC affirmative votes. > > > > > > > > > > > > > > > > Thanks, > > > > > > > > Arvid Heise > > > > > > > > > > > > > > > > [1] > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12354606 > > > > > > > > [2] > > > > > > > > > > https://dist.apache.org/repos/dist/dev/flink/flink-connector-kafka-3.3.0-rc1 > > > > > > > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS > > > > > > > > [4] > > > > > > > > > > https://repository.apache.org/content/repositories/staging/org/apache/flink/flink-connector-kafka/3.3.0-1.19.1/ > > > > + > > > > > > > > > > https://repository.apache.org/content/repositories/staging/org/apache/flink/flink-connector-kafka/3.3.0-1.20.0/ > > > > > > > > [5] > > > > https://github.com/apache/flink-connector-kafka/releases/tag/v3.3.0-rc1 > > > > > > > > [6] https://github.com/apache/flink-web/pull/757 > > > > > > > > [7] > > > > > > > > > > https://github.com/apache/flink-connector-kafka/actions/runs/11281680238/ > > > > > > > > >
