Thanks Danny for the hard work!

+1(binding)

- Verified signatures
- Verified sha512 (hashsums)
- The source archives do not contain any binaries
- Build the source with Maven 3 and java8 (Checked the license as well)
- Checked Github release tag
- Reviewed the flink-web PR

Best,
Rui

On Wed, May 22, 2024 at 8:07 PM Leonard Xu <xbjt...@gmail.com> wrote:

>
> +1 (binding)
>
> - verified signatures
> - verified hashsums
> - built from source code with java 1.8 succeeded
> - checked Github release tag
> - checked release notes
> - reviewed the web PR
>
> Best,
> Leonard
>
> > 2024年4月21日 下午9:52,Hang Ruan <ruanhang1...@gmail.com> 写道:
> >
> > +1 (non-binding)
> >
> > - Validated checksum hash
> > - Verified signature
> > - Verified that no binaries exist in the source archive
> > - Build the source with Maven and jdk8
> > - Verified web PR
> > - Check that the jar is built by jdk8
> >
> > Best,
> > Hang
> >
> > Ahmed Hamdy <hamdy10...@gmail.com> 于2024年4月18日周四 20:01写道:
> >
> >> Hi Danny,
> >> +1 (non-binding)
> >>
> >> -  verified hashes and checksums
> >> - verified signature
> >> - verified source contains no binaries
> >> - tag exists in github
> >> - reviewed web PR
> >>
> >> Best Regards
> >> Ahmed Hamdy
> >>
> >>
> >> On Thu, 18 Apr 2024 at 11:32, Danny Cranmer <dannycran...@apache.org>
> >> wrote:
> >>
> >>> Hi everyone,
> >>>
> >>> Please review and vote on release candidate #1 for
> >>> flink-connector-gcp-pubsub v3.1.0, as follows:
> >>> [ ] +1, Approve the release
> >>> [ ] -1, Do not approve the release (please provide specific comments)
> >>>
> >>> This release supports Flink 1.18 and 1.19.
> >>>
> >>> The complete staging area is available for your review, which includes:
> >>> * JIRA release notes [1],
> >>> * the official Apache source release to be deployed to dist.apache.org
> >>> [2],
> >>> which are signed with the key with fingerprint 125FD8DB [3],
> >>> * all artifacts to be deployed to the Maven Central Repository [4],
> >>> * source code tag v3.1.0-rc1 [5],
> >>> * website pull request listing the new release [6].
> >>> * CI build of the tag [7].
> >>>
> >>> The vote will be open for at least 72 hours. It is adopted by majority
> >>> approval, with at least 3 PMC affirmative votes.
> >>>
> >>> Thanks,
> >>> Danny
> >>>
> >>> [1]
> >>>
> >>>
> >>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12353813
> >>> [2]
> >>>
> >>>
> >>
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-gcp-pubsub-3.1.0-rc1
> >>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> >>> [4]
> >> https://repository.apache.org/content/repositories/orgapacheflink-1720
> >>> [5]
> >>>
> >>>
> >>
> https://github.com/apache/flink-connector-gcp-pubsub/releases/tag/v3.1.0-rc1
> >>> [6] https://github.com/apache/flink-web/pull/736/files
> >>> [7]
> >>>
> >>>
> >>
> https://github.com/apache/flink-connector-gcp-pubsub/actions/runs/8735952883
> >>>
> >>
>
>

Reply via email to