+1 (non-binding)

- Verified signature
- Verified checksum
- Built release tag from source with JDK 11
- approved docs PR

Best,
Fabian

On Wed, May 22, 2024 at 2:22 PM Leonard Xu <xbjt...@gmail.com> wrote:

> +1 (binding)
>
> - verified signatures
> - verified hashsums
> - built from source code with java 1.8 succeeded
> - checked Github release tag
> - reviewed the web PR
> - checked the CI result,
>               minor: the link [7] you post should be [1]
> - checked release notes,
>               minor: the issue FLINK-34961[2] should move to next version
>
>
> Best,
> Leonard
>
> [1]
> https://github.com/apache/flink-connector-kafka/actions/runs/8785158288
> [2] https://issues.apache.org/jira/browse/FLINK-34961
>
>
> > 2024年4月29日 上午12:34,Aleksandr Pilipenko <z3d...@gmail.com> 写道:
> >
> > +1 (non-binding)
> >
> > - Validated checksum
> > - Verified signature
> > - Checked that no binaries exist in the source archive
> > - Build source
> > - Verified web PR
> >
> > Thanks,
> > Aleksandr
> >
> > On Sun, 28 Apr 2024 at 11:35, Hang Ruan <ruanhang1...@gmail.com> wrote:
> >
> >> +1 (non-binding)
> >>
> >> - Validated checksum hash
> >> - Verified signature
> >> - Verified that no binaries exist in the source archive
> >> - Build the source with Maven and jdk8
> >> - Verified web PR
> >> - Check that the jar is built by jdk8
> >>
> >> Best,
> >> Hang
> >>
> >> Ahmed Hamdy <hamdy10...@gmail.com> 于2024年4月24日周三 17:21写道:
> >>
> >>> Thanks Danny,
> >>> +1 (non-binding)
> >>>
> >>> - Verified Checksums and hashes
> >>> - Verified Signatures
> >>> - Reviewed web PR
> >>> - github tag exists
> >>> - Build source
> >>>
> >>>
> >>> Best Regards
> >>> Ahmed Hamdy
> >>>
> >>>
> >>> On Tue, 23 Apr 2024 at 03:47, Muhammet Orazov
> >>> <mor+fl...@morazow.com.invalid>
> >>> wrote:
> >>>
> >>>> Thanks Danny, +1 (non-binding)
> >>>>
> >>>> - Checked 512 hash
> >>>> - Checked gpg signature
> >>>> - Reviewed pr
> >>>> - Built the source with JDK 11 & 8
> >>>>
> >>>> Best,
> >>>> Muhammet
> >>>>
> >>>> On 2024-04-22 13:55, Danny Cranmer wrote:
> >>>>> Hi everyone,
> >>>>>
> >>>>> Please review and vote on release candidate #1 for
> >>>>> flink-connector-kafka
> >>>>> v3.2.0, as follows:
> >>>>> [ ] +1, Approve the release
> >>>>> [ ] -1, Do not approve the release (please provide specific comments)
> >>>>>
> >>>>> This release supports Flink 1.18 and 1.19.
> >>>>>
> >>>>> The complete staging area is available for your review, which
> >> includes:
> >>>>> * JIRA release notes [1],
> >>>>> * the official Apache source release to be deployed to
> >> dist.apache.org
> >>>>> [2],
> >>>>> which are signed with the key with fingerprint 125FD8DB [3],
> >>>>> * all artifacts to be deployed to the Maven Central Repository [4],
> >>>>> * source code tag v3.2.0-rc1 [5],
> >>>>> * website pull request listing the new release [6].
> >>>>> * CI build of the tag [7].
> >>>>>
> >>>>> The vote will be open for at least 72 hours. It is adopted by
> >> majority
> >>>>> approval, with at least 3 PMC affirmative votes.
> >>>>>
> >>>>> Thanks,
> >>>>> Danny
> >>>>>
> >>>>> [1]
> >>>>>
> >>>>
> >>>
> >>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12354209
> >>>>> [2]
> >>>>>
> >>>>
> >>>
> >>
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-kafka-3.2.0-rc1
> >>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> >>>>> [4]
> >>>>>
> >> https://repository.apache.org/content/repositories/orgapacheflink-1723
> >>>>> [5]
> >>>>>
> >>>
> https://github.com/apache/flink-connector-kafka/releases/tag/v3.2.0-rc1
> >>>>> [6] https://github.com/apache/flink-web/pull/738
> >>>>> [7] https://github.com/apache/flink-connector-kafka
> >>>>
> >>>
> >>
>
>

Reply via email to