Hi Peter, It would be good if Gordon can take a look, but overall this looks good to me +1
Best regards, Martijn On Fri, Dec 22, 2023 at 8:25 AM Péter Váry <peter.vary.apa...@gmail.com> wrote: > > We have enough votes for the decision, but given that this is an important > change, and for many of us it is a holiday season, I plan to keep this vote > open until the 3rd of January. This way, if anyone else has comments and > suggestions then they have time to raise them. > > Thanks everyone for the votes, and Leonard for the useful suggestions! > > Happy holidays everyone! > > Peter > > On Thu, Dec 21, 2023, 11:23 Leonard Xu <xbjt...@gmail.com> wrote: > > > Thanks Peter for quick response and update. > > > > I’ve no more comments on the updated FLIP, +1. > > > > For the PR process, you could alsouse draft PR[1] to leverage the testing > > infra during POC phase, > > we usually create FLIP umbrella issue and subtask issues after the FLIP is > > accepted. > > > > > > Best, > > Leonard > > [1]https://github.com/apache/flink/pulls?q=is%3Apr+is%3Aopen+draft > > > > > > > > > > >> > > >> > > >> Best, > > >> Leonard > > >> > > >> > > >> > > >>> 2023年12月21日 上午11:47，Jiabao Sun <jiabao....@xtransfer.cn.INVALID> 写道： > > >>> > > >>> Thanks Peter for driving this. > > >>> > > >>> +1 (non-binding) > > >>> > > >>> Best, > > >>> Jiabao > > >>> > > >>> > > >>> On 2023/12/18 12:06:05 Gyula Fóra wrote: > > >>>> +1 (binding) > > >>>> > > >>>> Gyula > > >>>> > > >>>> On Mon, 18 Dec 2023 at 13:04, Márton Balassi <ba...@gmail.com> > > >>>> wrote: > > >>>> > > >>>>> +1 (binding) > > >>>>> > > >>>>> On Mon 18. Dec 2023 at 09:34, Péter Váry <pe...@gmail.com> > > >>>>> wrote: > > >>>>> > > >>>>>> Hi everyone, > > >>>>>> > > >>>>>> Since there were no further comments on the discussion thread [1], I > > >>>>> would > > >>>>>> like to start the vote for FLIP-372 [2]. > > >>>>>> > > >>>>>> The FLIP started as a small new feature, but in the discussion > > thread > > >> and > > >>>>>> in a similar parallel thread [3] we opted for a somewhat bigger > > >> change in > > >>>>>> the Sink V2 API. > > >>>>>> > > >>>>>> Please read the FLIP and cast your vote. > > >>>>>> > > >>>>>> The vote will remain open for at least 72 hours and only concluded > > if > > >>>>> there > > >>>>>> are no objections and enough (i.e. at least 3) binding votes. > > >>>>>> > > >>>>>> Thanks, > > >>>>>> Peter > > >>>>>> > > >>>>>> [1] - > > >> https://lists.apache.org/thread/344pzbrqbbb4w0sfj67km25msp7hxlyd > > >>>>>> [2] - > > >>>>>> > > >>>>>> > > >>>>> > > >> > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-372%3A+Allow+TwoPhaseCommittingSink+WithPreCommitTopology+to+alter+the+type+of+the+Committable > > >>>>>> [3] - > > >> https://lists.apache.org/thread/h6nkgth838dlh5s90sd95zd6hlsxwx57 > > >>>>>> > > >>>>> > > >> > > >> > > > >
