Thanks Leonard for the review! See my answers below:
Leonard Xu <xbjt...@gmail.com> ezt írta (időpont: 2023. dec. 21., Cs, 9:00): > Thanks Peter for driving this. > > The FLIP change is a big improvement of the existing sink v2 interfaces, > but the FLIP's overall API design taste and interface style looks good to > me. > > +1(binding) from my side. > > I also left a little minor comments we can improve later. > (1) The FLIP title dosen't cover the proposed change scope well, right? > Renamed to `Enhance and synchronize Sink API to match the Source API` > (2) The pseudocode filename of StatefulSinkWriter has a typo. > Fixed > (3) I’ve found you’ve open a PR in Github, we’d better create issue and > prepare a formal PR > until the FLIP passed instead of discussion status. > I used the PR to make sure that the implementation adds up. During my previous FLIP, I have found that while some of the ideas look good in a doc, the code disagrees. Flink has a quite good testing coverage, and helped me identify some of the issues. Also for this kind of changes for some developers it is easier to see the code than reading the doc. Definitely will start the review process of the PR without a proper jira and until the FLIP is accepted. > > > Best, > Leonard > > > > > 2023年12月21日 上午11:47，Jiabao Sun <jiabao....@xtransfer.cn.INVALID> 写道： > > > > Thanks Peter for driving this. > > > > +1 (non-binding) > > > > Best, > > Jiabao > > > > > > On 2023/12/18 12:06:05 Gyula Fóra wrote: > >> +1 (binding) > >> > >> Gyula > >> > >> On Mon, 18 Dec 2023 at 13:04, Márton Balassi <ba...@gmail.com> > >> wrote: > >> > >>> +1 (binding) > >>> > >>> On Mon 18. Dec 2023 at 09:34, Péter Váry <pe...@gmail.com> > >>> wrote: > >>> > >>>> Hi everyone, > >>>> > >>>> Since there were no further comments on the discussion thread [1], I > >>> would > >>>> like to start the vote for FLIP-372 [2]. > >>>> > >>>> The FLIP started as a small new feature, but in the discussion thread > and > >>>> in a similar parallel thread [3] we opted for a somewhat bigger > change in > >>>> the Sink V2 API. > >>>> > >>>> Please read the FLIP and cast your vote. > >>>> > >>>> The vote will remain open for at least 72 hours and only concluded if > >>> there > >>>> are no objections and enough (i.e. at least 3) binding votes. > >>>> > >>>> Thanks, > >>>> Peter > >>>> > >>>> [1] - > https://lists.apache.org/thread/344pzbrqbbb4w0sfj67km25msp7hxlyd > >>>> [2] - > >>>> > >>>> > >>> > https://cwiki.apache.org/confluence/display/FLINK/FLIP-372%3A+Allow+TwoPhaseCommittingSink+WithPreCommitTopology+to+alter+the+type+of+the+Committable > >>>> [3] - > https://lists.apache.org/thread/h6nkgth838dlh5s90sd95zd6hlsxwx57 > >>>> > >>> > >
